Does SqlDataAdapter.Dispose actually Close an associated SqlConnection?

3 thoughts on “Does SqlDataAdapter.Dispose actually Close an associated SqlConnection?”

1. user November 30, -0001 at 12:00 am

   Nope, it doesn’t dispose the connection. I believe it shouldn’t. You might want to use it elsewhere.

   Reply ↓
2. user November 30, -0001 at 12:00 am

   As far as I know it does not. I use nested Using statements to achieve this, create the connection first, then create the adapter and as the using statements “pop”, the adapter is Disposed, then the connection is Disposed, which does trigger a close:

   Using conn as New SqlConnection("")
       Using adapter as New SqlDataAdapter() With {.Connection = conn}
           'Do stuff'
       End Using
   End Using
   

   The syntax is virtually identical for C#, if that’s your language of choice.

   Reply ↓
3. user November 30, -0001 at 12:00 am

   The first thing to be aware of is the DataAdapter does manage and close your connection in some circumstances. For example, if you’re using a DataAdapter you’re probably operating on DataTable/DataSet using .Fill() and .Update() functions.

   From the .Fill() docs:

   The connection object associated with the SELECT statement must be valid, but it does not need to be open. If the connection is closed before Fill is called, it is opened to retrieve data, then closed. If the connection is open before Fill is called, it remains open.

   The .Update() docs don’t mention anything about the connection at all, so I would expect to need to manage it manually.

   You asked specifically about the Dispose() method. Like Update(), the Dispose() docs don’t specifically mention the connection, so I would expect to need to close it manually.

   Finally, we can improve on Bob King’s code slightly like this:

   Using conn as New SqlConnection(""), _
         adapter as New SqlDataAdapter() With {.Connection = conn}
       ' Do stuff
   End Using
   

   Or in C#:

   using (SqlConnection conn = new SqlConnection(""))
   using (SqlDataAdapter adapter = new SqlDataAdapter() {Connection = conn})
   {
       // Do stuff
   }
   

   Reply ↓